Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions affect the returned avatar #99

Open
rylnd opened this issue Apr 29, 2019 · 1 comment
Open

extensions affect the returned avatar #99

rylnd opened this issue Apr 29, 2019 · 1 comment

Comments

@rylnd
Copy link
Collaborator

rylnd commented Apr 29, 2019

We previously had code in place that made the requests /avatars/foo.png and /avatars/foo "the same;" it was accomplished by simply stripping the extension out of the identifier. I removed this code because I thought it was silly, but I realize now that it's really a stopgap for #19.

Avatar-wise, the extension should not affect the result. Long-term, it should affect the content-type of the response.

The main reason to fix this sooner rather than later is that the .png toggle on the avatars site now behaves "weirdly," in that it actually changes the avatar being displayed.

@qaisjp
Copy link

qaisjp commented Aug 10, 2019

Yeah the URL on the website gives a .png but the image displayed is without the .png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants