Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining issues identified by Konstantinos #20

Open
mpompolas opened this issue Apr 27, 2022 · 0 comments
Open

Remaining issues identified by Konstantinos #20

mpompolas opened this issue Apr 27, 2022 · 0 comments

Comments

@mpompolas
Copy link
Member

1. channel coordinates are hardcoded and not absolutely perfect.

We need to go from channel coordinates to NIFTI slice pixel coordinates. This is needed in the case of partial annotations during inference. The coordinates are currently affected by the screen resolution of the computer. Right now the converter uses Brainstorm's functions for creating the 2d topography for each slice.
A more correct approach would be to take the coordinates of the maximum number of channels we can encounter, and assign them uniquely to a 32x32 image (Ivadomed likes images that are multiples of 16. If 32 is not enough, next size is 48x48). Sequentially interpolate on that 32x32 image and create with that process the NIFTI 3D volumes.
NOTE: the interpolation method needs to become a hyperparameter.

2. some model predictions/annotations are overlapping due to the overlapping sliding windows - maybe create a mask before assigning events?

3. Check if loading of the Ivadomed plugin should be done automatically after installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant