Replies: 2 comments 3 replies
-
Actually having gone through Changed the base back to 'master' for #70 & #72 until 'next' is fixed for now. |
Beta Was this translation helpful? Give feedback.
-
Yes, that’s correct. The strategy allows anyone to make PRs. These are then squashed while maintaining the conventional commits specification, and as you pointed out, rebased to master to ensure users receive a stable release. I’ve made several hotfixes, so I believe implementing this strategy would be a better approach. |
Beta Was this translation helpful? Give feedback.
-
I appreciate the use of squash merge commits when merging PRs into
next
, it helps keep history tidy and highlights complete features. However, using squashes for merges fromnext
tomaster
erases the individual history of those PRs implementing new features, and the names of those who contributed (with as an example v1.5). There's also the problem of fixes and changes being implemented inmaster
but not being merged back intonext
.Would you consider maintaining
master
as the stable release, but rebase the currentnext
on top of it and keepingnext
as a PR target and straight fast-forward merge intomaster
on release day? This way individual PRs keep their status as an individual commit, without bloating history.Beta Was this translation helpful? Give feedback.
All reactions