Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not automatically prescribe the way TanhInterfaceSmoothing works #103

Closed
jbisits opened this issue Jan 7, 2025 · 1 comment
Closed
Labels
Project 3 Code development relating to the third project in my PhD

Comments

@jbisits
Copy link
Owner

jbisits commented Jan 7, 2025

Here I find the smoothing based off the initial conditions (which is good especially for single interface) but I prescribe the change over the interface as 100.0 (which is bad)

function set_initial_conditions!(model, ics, interface_smoothing::Type{<:Tanh}, background_state)
depth_of_interface = ics.depth_of_interface
Lz = model.grid.Lz
S = Array(ics.salinity_values)
Sᵤ, Sₗ = S
ΔS = diff(S)[1]
S₀(x, y, z) = Tanh(Sₗ, ΔS, 100.0, depth_of_interface, abs(Lz))(x, y, z)
T = Array(ics.temperature_values)
Tᵤ, Tₗ = T
ΔT = diff(T)[1]
T₀(x, y, z) = Tanh(Tₗ, ΔT, 100.0, depth_of_interface, abs(Lz))(x, y, z)
set!(model, S = S₀, T = T₀)
return nothing
end

Need to change this so user can add the steepness of the change.

@jbisits jbisits added the Project 3 Code development relating to the third project in my PhD label Jan 7, 2025
@jbisits
Copy link
Owner Author

jbisits commented Jan 7, 2025

Closed with #104

@jbisits jbisits closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project 3 Code development relating to the third project in my PhD
Projects
None yet
Development

No branches or pull requests

1 participant