Executing shell commands no longer works with fish as shell

[peppy]

To Reproduce

Run a custom shell command with fish set as shell.

iTerm2.2025-01-07.at.09.18.34.mp4

❯ lazygit --version
commit=, build date=, build source=homebrew, version=HEAD-13829d8, os=darwin, arch=arm64, git version=2.47.1

❯ git --version
git version 2.47.1

[stefanhaller]

Damn, this whole "use an interactive shell for running custom commands" feature keeps causing problems. A similar error happens with nushell.

A workaround could be to define an alias or function for lazygit that exports SHELL=/bin/bash before calling lazygit.

As for a fix, maybe we should look at the $SHELL variable and only do the interactive thing if it ends with either /bash or /zsh (any others that are commonly used?), and fall back to calling bash (without -i) if not.

[peppy]

I'll do the shell export thing for now as a workaround, thanks for the suggestion.

I also noticed an occasional command failure when doing a lazygit amend operation that seemed to be similarly shell related – I'll post if it pops up again.

These kind of issues do make me consider switching back to zsh 😅

[stefanhaller]

@peppy Here's a quick and dirty fix if you want to try it: #4159

[peppy]

Thank you, it works great.