FilestoreIntegrity plugin ignores different binarystore data directories

[patbat95008]

Symptoms:
When running the filestoreIntegrity plugin execution endpoint, the plugin will only look in the local Artifactory data directory, unless a different one is specified in an HA configuration. This results in unintended errors, such as reporting all Artifactory binaries are missing.

Steps to reproduce:

1. Move a healthy Artifactory filestore to a simulated mount in a different location
2. Modify the Binarystore.xml as per the documentation to point to the "NFS mount" alternate location
3. Load the plugin,
4. Either see an incorrect assessment (If the "filestore" directory still exists) or a 500 error:
   {
   "errors" : [ {
   "status" : 500,
   "message" : "Error reading files from '/home/jfrog/programs/artifactory-pro-5.2.1/data/filestore': the directory is either empty, inaccessible, or gone. This Artifactory instance may be using a binary provider that is unsupported by this plugin."
   } ]
   }

Workaround: Symlink the $ARTIFACTORY_HOME/data/filestore folder to point to the actual filestore mount.

[DarthFennec]

Suggested workaround looks good. Short term fix would be to find a way to extract the real directory location from the binarystore config.

Long term fix is to use Artifactory's internal binarystore API. This wouldn't be much slower for local storage, and it would work with all other filestores (sharding, S3, etc), which would make that horrible python script mostly obsolete.

[arturo-aparicio]

Marking this as a feature request. We already document this limitation with the tool and provide an alternative method. If we take this up, we should also account for other scenarios and do something reasonable:
S3, Sharding, custer storage, etc.

[shashank-jfrog]

Hi

The above issue is a known limitation to the plugin and the suggested solution is here. As this is a deprecated plugin and we are not taking feature requests. As you can see in our documentation we are working on a newer, recommended way to extend the JFrog Platform (including artifactory) in a cloud-native way, called JFrog Workers.

We’ll close this ticket for now, but if you have any further questions or need additional assistance, don’t hesitate to reopen it.

Thanks