-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Make the Delete button optional to be shown #23
Comments
Hey @mental1337! I have been working on improving this plugin and have solved your issue in V1.9.0 in the Beta version. I have submitted the changes to the author of Cards View to be merged with the main plugin : #27 But meanwhile, you can try the Beta version from here : Cards View (Beta) Happy to listen from you for more suggestion to make this plugin even better. |
Hello ! @tu2-atmanand, if you want to contribute this feature in a single PR following the new contributing guidelines, you are very welcome to do so. |
I would love to submit my contributions to integrate this functionality. But first, I think it will be nice if we discuss this and finish it off : #28 Because, all my subsequent changes are majorly dependent on my first commit, where I have changed the project structure a little bit. So once we do that part and everything has been merged in the main codebase. Then I can proceed with submitting my further contributions for the different things I have implemented in my fork. |
Created a new PR for this feature : #29 |
It is too easy to accidentally delete a note from the card view using the prominent Delete icon at the bottom of each card. It should either not be shown or be optional. Also, it seems it deletes the file directly without sending to /.trash which makes it scarier.
The text was updated successfully, but these errors were encountered: