Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Make the Delete button optional to be shown #23

Open
mental1337 opened this issue Nov 17, 2024 · 4 comments
Open

[FR] Make the Delete button optional to be shown #23

mental1337 opened this issue Nov 17, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@mental1337
Copy link

It is too easy to accidentally delete a note from the card view using the prominent Delete icon at the bottom of each card. It should either not be shown or be optional. Also, it seems it deletes the file directly without sending to /.trash which makes it scarier.

@tu2-atmanand
Copy link

tu2-atmanand commented Dec 1, 2024

Hey @mental1337!

I have been working on improving this plugin and have solved your issue in V1.9.0 in the Beta version. I have submitted the changes to the author of Cards View to be merged with the main plugin : #27

But meanwhile, you can try the Beta version from here : Cards View (Beta)

Happy to listen from you for more suggestion to make this plugin even better.

@jillro
Copy link
Owner

jillro commented Dec 11, 2024

Hello ! @tu2-atmanand, if you want to contribute this feature in a single PR following the new contributing guidelines, you are very welcome to do so.

@tu2-atmanand
Copy link

I would love to submit my contributions to integrate this functionality. But first, I think it will be nice if we discuss this and finish it off : #28

Because, all my subsequent changes are majorly dependent on my first commit, where I have changed the project structure a little bit. So once we do that part and everything has been merged in the main codebase. Then I can proceed with submitting my further contributions for the different things I have implemented in my fork.

@tu2-atmanand
Copy link

Created a new PR for this feature : #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants