Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails in node 9 #283

Open
Thrillpool opened this issue Mar 29, 2023 · 0 comments
Open

Fails in node 9 #283

Thrillpool opened this issue Mar 29, 2023 · 0 comments

Comments

@Thrillpool
Copy link

More an observation than anything else, since the readme does only guarantee support from node 12 onwards, though actually to me it looks like it would fail until node 14.

Anyway, the problem is that after this change

c843d47#diff-0f66bae7ebf6d343f3d4cb0a5dedb7517273148cfd2e7d8f6bcc892f90e63a2aR8

the dist has a ?. in this one file, which node 9 doesn't interpret correctly.

Easily resolved locally by just changing the file a bit after installing.

So it could either be changed back to the node 9 compatible way of checking, or just the readme be updated.

All that being said, https://node.green/#ES2020-features-optional-chaining-operator------optional-property-access seems to suggest that actually this feature isn't available until node 14.

Brilliant library by the way. Very useful, I was writing something very similar myself and then found this - which is much better than my implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant