Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHLO support - rfc2033 #3

Open
jocutajar opened this issue Nov 27, 2020 · 2 comments
Open

LHLO support - rfc2033 #3

jocutajar opened this issue Nov 27, 2020 · 2 comments

Comments

@jocutajar
Copy link

jocutajar commented Nov 27, 2020

Hi, I've just successfully integrated rustyknife into samotop as a second parser. I'd like to make it the default and swap out the PEG parser I've written.

One thing I'm missing is the LHLO command so that server can serve local delivery. With that perhaps also SEND, SOML SAML variants of MAIL to be feature complete for rfc821.

I suspect it should be trivial to add as the syntax is otherwise identical with EHLO/MAIL.

@jothan
Copy link
Owner

jothan commented Dec 4, 2020

I don't plan on supporting obsolete RFC 821 commands at this time, you may submit a patch for these.

As adding LHLO support is trivial, I will add it.

Don't hesitate to provide any other feedback, I'm not exactly great at designing APIs :).

@jocutajar
Copy link
Author

other feedback

Thanks. You can check my adapter for rustyknife - I think the API is decent and I like how you solved the UTF-8/ASCII dilemma.

One thing is the nom Err - it would be great to re-export it so that dependent crates don't have to depend on nom just to act on the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants