Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The role to publish the joint model to spinal #663

Open
tongtybj opened this issue Jan 17, 2025 · 3 comments
Open

The role to publish the joint model to spinal #663

tongtybj opened this issue Jan 17, 2025 · 3 comments
Assignees

Comments

@tongtybj
Copy link
Collaborator

Currently, the joint model is published from servo_bridge to spinal: https://github.com/jsk-ros-pkg/jsk_aerial_robot/blob/master/aerial_robot_model/src/servo_bridge/servo_bridge.cpp#L399-L423.

But I think the should be better place to publish this topic simultaneously with uav_info.

@sugihara-16
Copy link
Collaborator

Yeah, it's the more appropriate way.
I just wanted to utilize some existing code structures in servo bridge to treat joint parameters.

@tongtybj
Copy link
Collaborator Author

Yeah, I do understand your purpose.
First of all, the mechanism and the place of publishing uav_model can be still improved
Let's refactor these functions in the near future.

@sugihara-16
Copy link
Collaborator

OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants