You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This covers a list of API changes suggested in the tablesaw repo. See original description below and original issue: jtablesaw/tablesaw#716
I'm not sure what's left to do here that makes sense so a review is needed.
I would like to suggest some simple API changes to the jsplot-plotly classes which will slowly help in the direction proposed in issue jtablesaw/tablesaw#693. If these suggestions sound acceptable, I can work on a PR.
Figure.java : Change methods buildContext(), plotFunction(), eventHandlerFunction to "protected" instead of "private" so that they can be overridden.
For all Plot classes in tech.tablesaw.plotly.api.*, extend the classes to Figure.java.
Make the constructor of Heatmap (tech.tablesaw.plotly.api) public.
For all *Plot classes create constructors with parameters that match the static create() methods of each class, with an added Layout object. The constructors would do the same as the static methods except that it would setXXX() the layout, trace and eventhandlers instead of creating a new Figure.
If these changes are made, then the following will be true :
a) It will not break the current API.
b) It will allow users of Tablesaw to set a custom Layout object for each of the Plot classes.
c) It will allow users of Tablesaw to take advantage of inheritance and create classes which extend the Plot classes and override the underlying methods, so that they can make enhancements or changes to the current implementation.
d) It will allow users of Tablesaw to contribute their enhancements to the Tablesaw project, but still use their custom enhancements and the latest Tablesaw release while waiting for the acceptance of the enhancements and a new release with the changes.
The text was updated successfully, but these errors were encountered:
This covers a list of API changes suggested in the tablesaw repo. See original description below and original issue: jtablesaw/tablesaw#716
I'm not sure what's left to do here that makes sense so a review is needed.
The text was updated successfully, but these errors were encountered: