-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change query param to path param #486
Comments
For this, it's better to save fetch result in another file containing contact list. If it's in current structure, I made a sample implementation here https://github.com/ekamuktia/wargabantuwarga.com/tree/kebutuhan-slug bandicam.2021-07-29.19-27-22-417.mp4If I choose province, should I change the path? It's still buggy, but in this implementation it's just redirected to new page If it's using typesense, |
If using current JSON data, yes I also think we need to split the current JSON with a different subset. e.g: All contact data in all provinces, contact data in spesific provinces, contact data for spesific kebutuhan in all provinces, contact data for spesific kebutuhan in specific province, etc. It will be easier to provide the initial data on the staticProps |
Got it, will do it along all updated formats tonight. I'll let you know once it's done @ekamuktia . |
All set @ekamuktia . I've also added sortable fields named |
Description
Currently, we utilize the query param to differentiate the "kebutuhan" selection.
Since these selections already bring to the main homepage and the menus, I think we need to think to create a separate path URL for this use case:
Sample current condition:
Expectations
We need to change the query param to path param, e.g:
With this implementation, we also open the opportunity to generate spesific province for spesific "kebutuhan", e.g:
Implementation Model
Still have no idea, but since I guess the logic should be nearly same with the current implementation, maybe need to move the current provinces page logic to the place where we can reuse the logic part.
But ya, for the filters, it need to be re-touched.
Possible benefits
Tasks
Didn't have any task lists for now, need insight from other contributors.
The text was updated successfully, but these errors were encountered: