Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect syntax coloring in /- comment of first example #41

Closed
DanielGibson opened this issue Jan 8, 2025 · 4 comments
Closed

Incorrect syntax coloring in /- comment of first example #41

DanielGibson opened this issue Jan 8, 2025 · 4 comments

Comments

@DanielGibson
Copy link

At least on my system (with current Firefox), it looks like this:
Image
shouldn't the second } also be greyed out, as it's (to my understanding, which is just from looking at the examples ;)) part of the commented out node

@zkat
Copy link
Member

zkat commented Jan 8, 2025

ah yes, thanks for filing an actual issue. I knew about this, but I haven't figured out how to work around it yet.

Closing in favor of kdl-org/vscode-kdl#18

@zkat zkat closed this as completed Jan 8, 2025
@DanielGibson
Copy link
Author

I guess if properly fixing this is hard, as a workaround you could do manual coloring (by embedding raw html into md) - or not use syntax coloring at all there.

Otherwise this can lead to confusion, I think. Especially as this example is the first thing people see on kdl.dev - at least I wasn't 100% sure if this is a bug or if I just misunderstood something.

@zkat
Copy link
Member

zkat commented Jan 8, 2025

I think it's possible. I'm not sure it's hard per-se, rather "I don't actually know how to do this in TextMate grammars", and those grammars are... actually kinda weird and tricky sometimes. I'd like this to be properly fixed rather than fall back to manually putzing around with the html.

@DanielGibson
Copy link
Author

makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants