Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give interactive, uninstall #214

Open
kevincobain2000 opened this issue Nov 25, 2024 · 4 comments
Open

Give interactive, uninstall #214

kevincobain2000 opened this issue Nov 25, 2024 · 4 comments

Comments

@kevincobain2000
Copy link
Owner

kevincobain2000 commented Nov 25, 2024

ASIS

╰─$ gobrew uninstall
[Error] No version provided

TOBE

╰─$ gobrew uninstall
1.22.0
1.22.3  ◀ (INTERACTIVE)
1.22.8
1.22.9
1.23.0
1.23.1
1.23.3*
Are you sure you want to remove y/N?

Similar for install

ASIS

╰─$ gobrew install
[Error] No version provided
gobrew install
latest
dev-latest  ◀ (INTERACTIVE)
Provide a version: 
@juev
Copy link
Collaborator

juev commented Nov 25, 2024

What if I need to uninstall multiple versions at once? Will I have to run uninstall for each version? Now I like how Prune works. Its leaves only one version, which is used now.

The idea of making a separate uninstall is interesting. But we need to think about how to implement it correctly.

@kevincobain2000
Copy link
Owner Author

Good point
In that case the interface should be a multiselect.

gobrew uninstall
[ ] select all
[x] 1.22.0
[x] 1.22.3
[x] 1.22.8
[ ] 1.22.9
[x] 1.23.0
[ ] 1.23.1
1.23.3*

Note that there are no changes to existing gobrew uninstall <version> and gobrew prune

@kevincobain2000
Copy link
Owner Author

The idea of making a separate uninstall is interesting.

Not a separate uninstall, but more like, current gobrew uninstall can still be interactive when user doesn't give any version specifically.

@juev
Copy link
Collaborator

juev commented Nov 25, 2024

I didn't say it right, I meant a separate implementation of interactive user interaction. I really like the multi-select option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants