Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font(KbdKhmr): 2 symbols show up as tofu #3229

Open
Nnyny opened this issue Dec 3, 2024 · 8 comments
Open

font(KbdKhmr): 2 symbols show up as tofu #3229

Nnyny opened this issue Dec 3, 2024 · 8 comments

Comments

@Nnyny
Copy link
Contributor

Nnyny commented Dec 3, 2024

I'm working on Khmer Angkor version 2.0 and notice that the KbdKhmr font display ฿ and ‱ as tofu. Also, hint displays on iOS is slightly different than Android.

iOS:
Image

Android:
Image

@Nnyny
Copy link
Contributor Author

Nnyny commented Dec 6, 2024

FYI @mcdurdin .

@mcdurdin
Copy link
Member

mcdurdin commented Dec 6, 2024

Which hints are the issue? ាំ displays incorrectly on iOS; are there others?

Oh I see the coeng are also without dotted circles.

@mcdurdin
Copy link
Member

mcdurdin commented Dec 6, 2024

FYI @Nnyny, I think the hint display is a compiler bug, so we'll look at fixing this in the compiler in 18.0, so no need to wait for this in order to deploy the keyboard.

The tofu for ฿ and ‱ requires an update to KbdKhmr font I think.

@Nnyny
Copy link
Contributor Author

Nnyny commented Dec 6, 2024

Noted! Should I add these 2 symbols into release\shared\fonts\kbd\kbdkhmr.json ?

@mcdurdin
Copy link
Member

mcdurdin commented Dec 6, 2024

Noted! Should I add these 2 symbols into release\shared\fonts\kbd\kbdkhmr.json ?

The symbols can be added to the JSON file but also need to be added to the KbdKhmr font itself.

@Nnyny
Copy link
Contributor Author

Nnyny commented Dec 6, 2024

So should I wait for the font to be updated before I deploy the keyboard?

@mcdurdin
Copy link
Member

mcdurdin commented Dec 6, 2024

Yes, perhaps we need to wait on the font (although both of those characters could just be removed from the keyboard, because in my opinion neither of them are critical to the use of Khmer)

@Nnyny
Copy link
Contributor Author

Nnyny commented Dec 6, 2024

I will remove them instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@mcdurdin @Nnyny and others