Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): Error: 4054 Statement extended is not currently supported in context message is unclear #11022

Closed
mcdurdin opened this issue Mar 19, 2024 · 1 comment
Assignees
Milestone

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Mar 19, 2024

Reported at https://community.software.sil.org/t/error-4054-statement-extended-is-not-currently-supported-in-context/8571

This error message actually means 'you cannot use keys in the context part of the rule` (and will never be able to because it's a logical impossibility!)

So two things:

  • It is suggesting future support for the concept with the word 'currently'
  • 'extended' is internal babble exposed to the unsuspecting user

It would also help to reference the documentation at https://help.keyman.com/developer/language/guide/rules

At the same time as updating the error message, let's add a clarifying para on that page: the documentation already helps to differentiate between the different parts of a rule, but given how the understanding of 'a sequence of keystrokes' vs 'existing context + a keystroke' is so common, we should probably also add clarification of that specific idea.

@mcdurdin mcdurdin added this to the 18.0 milestone Mar 19, 2024
@mcdurdin mcdurdin modified the milestones: 18.0, A18S5 Apr 29, 2024
@mcdurdin mcdurdin self-assigned this Apr 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S5, A18S7 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@mcdurdin
Copy link
Member Author

This was fixed by #9908 -- new error message in .kmx compile phase that means this one can no longer be emitted (because this was raised in .js compile phase, after .kmx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants