Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(web): iPad emulator has the banner narrowed and not output the suggested word #4943

Closed
MakaraSok opened this issue Apr 21, 2021 · 5 comments
Milestone

Comments

@MakaraSok
Copy link
Collaborator

MakaraSok commented Apr 21, 2021

Describe the bug

iPad emulator has the banner narrowed and not output the suggested word when pressing the lower half of the banner.

Expected behavior

The banner should be shown in full for Khmer text to be readable.

Screenshots

The subscript and parts below the base are cropped off.
image


KeymanWeb:

  • OS: Windows 10 Pro 20H2 x64
  • Browser: Chrome Version 90.0.4430.72 (Official Build) (64-bit)
  • KeymanWeb Version: 14.0.271
  • URL: n/a

Keyboard and model

@mcdurdin
Copy link
Member

Is the word suggestion issue related to #4953? If so, let's make this only about the banner height. Does the banner height issue arise for native iPad devices?

@mcdurdin mcdurdin added this to the A15S4 milestone May 10, 2021
@MakaraSok
Copy link
Collaborator Author

Is the word suggestion issue related to #4953? If so, let's make this only about the banner height.

Different. Nothing is output in the text field when pressing the lower half of the banner on iPad emulator.

Does the banner height issue arise for native iPad devices?

@jahorton Do you have a device within reach to help and confirm this? Thanks.

@jahorton
Copy link
Contributor

If you press the lower half of the banner, often KMW thinks you're pressing a key on the first row instead.

No iPad within reach here, sorry. Only Simulated, but that requires being in macOS, which then precludes running the Developer test host.

@mcdurdin mcdurdin modified the milestones: A15S4, A15S5 May 14, 2021
@jahorton jahorton modified the milestones: A15S5, A15S8 May 28, 2021
@mcdurdin mcdurdin modified the milestones: A15S8, A15S9 Jul 12, 2021
@mcdurdin mcdurdin modified the milestones: A15S9, A15S10 Jul 26, 2021
@mcdurdin mcdurdin modified the milestones: A15S10, A15S11 Aug 9, 2021
@mcdurdin mcdurdin modified the milestones: A15S11, A15S12 Aug 23, 2021
@mcdurdin mcdurdin modified the milestones: A15S12, A15S13 Sep 6, 2021
@mcdurdin mcdurdin modified the milestones: A15S13, A15S14 Sep 18, 2021
@mcdurdin mcdurdin modified the milestones: A15S14, A15S15 Oct 4, 2021
@darcywong00 darcywong00 modified the milestones: A15S15, A15S16 Oct 17, 2021
@darcywong00 darcywong00 modified the milestones: A15S16, A15S17 Oct 30, 2021
@mcdurdin mcdurdin modified the milestones: A15S17, A15S18 Nov 14, 2021
@mcdurdin
Copy link
Member

In the latest build (using artifacts from #5923), I found that the predictive text banner was no longer cropped:

image

I also found that it emitted the word as expected in all cases.

Can you repro this with that version from #5923, @MakaraSok?

@mcdurdin mcdurdin modified the milestones: A15S18, 15.0 Nov 17, 2021
@ermshiperete ermshiperete modified the milestones: 15.0, B15S5 Feb 18, 2022
@mcdurdin
Copy link
Member

Assuming this is fixed, @MakaraSok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants