Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Default Download CutOff and Retention Values #451

Open
warieon opened this issue Nov 3, 2024 · 5 comments
Open

[FR] Default Download CutOff and Retention Values #451

warieon opened this issue Nov 3, 2024 · 5 comments
Assignees

Comments

@warieon
Copy link

warieon commented Nov 3, 2024

Is your feature request related to a problem? Please describe.
When setting up pinchflat and adding sources, a user may want to set up multiple channels, and have those use the same / set a default date for the cut off date and use the same / a default retention period.

Describe the solution you'd like
Allow a cut off date options of "This month" or "Last 2/3 months" or similar - providing a rolling cut off date of the same interval period. Could also be weeks where the user can define default cut off date of last 6 weeks, enabling comparison of current date to determine the cut off date for the series.

The retention period should be able to be configured in Settings.

Both of these should be able to be defined in the Settings - perhaps the first source configured on initial app setup can pre-populate the default values in the Settings.

Describe alternatives you've considered
A user may want to define a specific cut off date; however, this could be a changing/moving date in a year's time (ie, today I want 2024-10-30, but next year, I might want 2025-05-30 because I only want to pull videos from the last month when creating the source.

@kieraneglin
Copy link
Owner

Hey there! Thanks for the request (:

I think I understand what you're looking for, but I have a few questions to make sure I'm looking at this the right way:

  • Can you please restate the goal this feature hopes to achieve? Is this about creating one less thing to think about by adding some quick-select options for retention period like Last week, Last month, and Last year?
  • Can you confirm my understanding that this is really an ask for two separate features? One being "make it easier to select common date offsets when creating a source" and the other being "add a setting that acts as the default date offset when creating new sources"? I see them as separate (ie: I could technically add one without the other and it would still provide some benefit), but if you see them as inextricably linked please let me know!

@warieon
Copy link
Author

warieon commented Nov 5, 2024

Hey,
No problem - thanks for the project - it may be alpha, but it looks really promising!

The goal is:
Streamline the process of adding new sources by pre-populating commonly used settings.

The Download CutOff Date is where it would be good to have the quick select options - I'm particularly wondering if this field is auto-defaulted as per the above goal, then a user opting to not set a retention period could end up downloading all videos for a channel from that date, when perhaps they didn't intend to. For example, today I configured a couple sources and set them to 1/11/2024 as the cut off date. If this date is saved as this date, then next year when I add another source, I don't want the cut off date to be 1/11/24 - I'll want the date to be 1 week before the source was added.

I agree that the two features can be added separately - there's also the feature for the retention period to be saved and prepopulated. Happy to separate that out as a separate issue if you'd like.

Could also have a "preference setting" for the fast indexing of sources to be another pre-populated setting, but that perhaps should be a separate feature? (although does fall under the same goal above)

@kieraneglin
Copy link
Owner

Got it! Focusing on just the quick-select options for now, I think that's something that makes total sense and would be easy enough to add. I'll add that to the list and then we can go from there with the other suggestions!

@robertkleinschuster
Copy link
Contributor

I also think that it would be a good idea to change the default behavior here because I think it is more common to want some kind of limit by default so you don't end up downloading everything a channel ever uploaded by default.

I wanted to try and have a go at implementing it but have no experience with dev containers and am running into an issue on my Apple Silicon Mac and Docker not being able to mount the workspaces directory.

@kieraneglin
Copy link
Owner

(note to self) some more suggestions here: #492 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants