Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tests for ArbitrablePermissionList #139

Open
clesaege opened this issue Oct 9, 2018 · 8 comments
Open

Make Tests for ArbitrablePermissionList #139

clesaege opened this issue Oct 9, 2018 · 8 comments

Comments

@clesaege
Copy link
Member

clesaege commented Oct 9, 2018

https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/permission/ArbitrablePermissionList.sol

@clesaege clesaege changed the title Make test for arbitrable permission list Make tests for arbitrable permission list Oct 9, 2018
@heypran
Copy link

heypran commented Oct 28, 2018

I am interested in taking this up..
started working on this

@heypran
Copy link

heypran commented Oct 28, 2018

What is the significance of the item that we are trying to register?

@heypran
Copy link

heypran commented Oct 28, 2018

I have a doubt it in the below scenario -

    /**
     *  @dev Appeal ruling. Anyone can appeal to prevent a malicious actor from challenging its own submission and losing on purpose.
     *  @param _value The value of the item with the dispute to appeal on.
     */
    function appeal(bytes32 _value) public payable {
        Item storage item = items[_value];
        arbitrator.appeal.value(msg.value)(item.disputeID,arbitratorExtraData); // Appeal, no need to check anything as the arbitrator does it.
    }

The scenario says that appeal can be made to prevent a malicious actor from challenging its own submission and losing on purpose.
Suggestion: This can be prevented by adding a require(item.submitter !=msg.sender) in the challenge functions

@epiqueras
Copy link
Contributor

epiqueras commented Oct 28, 2018 via email

@heypran
Copy link

heypran commented Oct 29, 2018

How should I submit the test code?

@epiqueras
Copy link
Contributor

Through a pull request. But I think @mtsalenc was already working on this?

@heypran
Copy link

heypran commented Oct 29, 2018

I have submitted a pull request #164, request a review.

@epiqueras epiqueras changed the title Make tests for arbitrable permission list Make Tests for Arbitrable Permission List Nov 12, 2018
@epiqueras epiqueras changed the title Make Tests for Arbitrable Permission List Make Tests for ArbitrablePermissionList Nov 15, 2018
@pasDamola
Copy link

Hi @clesaege is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants