-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note gets uploaded early #18
Comments
That's my changeset now: https://www.openstreetmap.org/changeset/119404789 |
I tried to recreate with the master-dev JOSM install and couldn't. I will install all the plugins from my normal install one by one to see if I can make this issue show up again. |
Ah. So this happens because of the way I'm currently figuring out if the upload worked. I'm looking for an Event called
Found a way to look out for the Property that determines if a layer needs an upload. That will change the way of processing the note Uploads. Maybe this also clears #16, let's see. |
So ... while #16 hasn't had any improvements ... is THIS still happening? |
Hm, haven't worked a lot with notes for a while, but can't say I remember this showing up again. I probably would have posted it here 😉 |
Fixed - not sure by which change. |
Can you reopen this? |
I set this note https://www.openstreetmap.org/note/3019711 to be remembered after I added a comment to it. Then I fixed the error there and made some minor edits in the area. I moved this https://www.openstreetmap.org/node/245779053 a bit and pressed "M" to merge it with the next node. Just after that, the "uploading changed notes" popup showed up for a short time. I checked and saw that indeed the note was uploaded (with comment) and closed by noteSolver. The autosolve note mentions https://www.openstreetmap.org/changeset/47061934 which happens to be the changeset that last touched that node.
I still haven't uploaded my changeset... but here are the gists for the JOSM --debug output and the JOSM status info.
This seems to be the same thing that you noticed in #11
The text was updated successfully, but these errors were encountered: