Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note gets uploaded early #18

Closed
daganzdaanda opened this issue Apr 6, 2022 · 8 comments
Closed

Note gets uploaded early #18

daganzdaanda opened this issue Apr 6, 2022 · 8 comments

Comments

@daganzdaanda
Copy link

I set this note https://www.openstreetmap.org/note/3019711 to be remembered after I added a comment to it. Then I fixed the error there and made some minor edits in the area. I moved this https://www.openstreetmap.org/node/245779053 a bit and pressed "M" to merge it with the next node. Just after that, the "uploading changed notes" popup showed up for a short time. I checked and saw that indeed the note was uploaded (with comment) and closed by noteSolver. The autosolve note mentions https://www.openstreetmap.org/changeset/47061934 which happens to be the changeset that last touched that node.
I still haven't uploaded my changeset... but here are the gists for the JOSM --debug output and the JOSM status info.

This seems to be the same thing that you noticed in #11

@daganzdaanda
Copy link
Author

daganzdaanda commented Apr 6, 2022

That's my changeset now: https://www.openstreetmap.org/changeset/119404789
The changeset comment was not pre-filled.

@daganzdaanda
Copy link
Author

image
The keyboard shortcut M is for merge, but the NoteSolver entry seems a little odd.

@daganzdaanda
Copy link
Author

I tried to recreate with the master-dev JOSM install and couldn't.
https://master.apis.dev.openstreetmap.org/changeset/234135#map=16/80.0685/12.5076&layers=ND
https://master.apis.dev.openstreetmap.org/note/30261

I will install all the plugins from my normal install one by one to see if I can make this issue show up again.

@kmpoppe
Copy link
Owner

kmpoppe commented Jun 13, 2022

Ah.

So this happens because of the way I'm currently figuring out if the upload worked. I'm looking for an Event called CHANGESET_ID_CHANGED which fires when you upload the OsmData you changed and the objects in the changeset get assigned the new changeset ID. What you're doing is merging two Objects, which in turn, I would guess, changes the Changeset Id of one or both Objects - that then uploads the notes.

Will need to find a way to hook into the onPostUploadToServer of the OsmDataLayer, but that's really not that easy.

Found a way to look out for the Property that determines if a layer needs an upload. That will change the way of processing the note Uploads. Maybe this also clears #16, let's see.

kmpoppe added a commit that referenced this issue Jun 13, 2022
Changed behaviour of Note Upload to check for more events and their order so that a more consistent behaviour should be reached.

This aims to address #16 and #18 and requires some testing.
@kmpoppe
Copy link
Owner

kmpoppe commented Feb 14, 2023

So ... while #16 hasn't had any improvements ... is THIS still happening?

@daganzdaanda
Copy link
Author

Hm, haven't worked a lot with notes for a while, but can't say I remember this showing up again. I probably would have posted it here 😉
So I guess it's likely this fix has worked... you could close the issue, and if I notice something again, I'll let you know anyhow.

@kmpoppe
Copy link
Owner

kmpoppe commented Apr 10, 2023

Fixed - not sure by which change.

@kmpoppe kmpoppe closed this as completed Apr 10, 2023
@daganzdaanda
Copy link
Author

Can you reopen this?
Unfortunately, it looks like this has not been solved.
See #16 (comment) and #16 (comment)
I described what I did to get the sudden late upload and it was the same sequence twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants