Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document KafkaSource v1 API #6201

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Document KafkaSource v1 API #6201

merged 1 commit into from
Jan 22, 2025
+11 −11

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jan 21, 2025 •
edited
Loading

@pierDipi
Document KafkaSource v1 API
ace4da9 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from mmejia02 and skonto January 21, 2025 15:48
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ace4da9
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/678fc1c39e65ff0008db54b7
😎 Deploy Preview https://deploy-preview-6201--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pierDipi
Copy link
Member Author

/cc @matzew @aliok @creydr

@knative-prow knative-prow bot requested review from aliok, creydr and matzew January 21, 2025 15:49
matzew
matzew approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fed9152 into knative:main Jan 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@mmejia02 mmejia02 Awaiting requested review from mmejia02

@skonto skonto Awaiting requested review from skonto

@aliok aliok Awaiting requested review from aliok

@creydr creydr Awaiting requested review from creydr

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1 API for KafkaSource
2 participants
@pierDipi @matzew