Abs does == of views of type different types

[csiefer2]

In Trilinos' KokkosBlas1_abs_impl.hpp:228 V_Abs_generic checks for equivalence views of two different types with an == . This is no bueno.

trilinos/Trilinos#2894

[crtrott]

I was first wondering how the heck this could drop through our testing framework. Turns out we run a unit test where BOTH the input and output for the function are of the same scalar type. I.e. we run something like

View<complex<double>*> r("R",N);
View<complex<double>*> a("A",N);
abs(r,a);

[crtrott]

We can do a simple fix and use something like the following instead of the current comparison:

if(std::is_same<X::array_layout,A::array_layout>::value &&
   std::is_same<X::memory_space,A::memory_space>::value &&
   ( (void*) (x.data()) == (void*) (a.data()) ) &&
   (x.extent(0) == a.extent(0)) )

[mhoemmen]

@crtrott If the pointers are the same but the extents aren't, you're kind of in trouble :-D

[crtrott]

Actually you are right that extent comparison is probably intercepted somewhere else.