Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserID as parameter for Methods? Use this.userId instead at server side? #40

Open
heberallred opened this issue Dec 20, 2018 · 1 comment

Comments

@heberallred
Copy link

Is there a reason you are passing the UserID from the client to the server in the methods? It seems this would be a security issue (not major since it's not able to access a lot of data), but would allow a user to spoof any user is online/offline by passing their userId to the method. It seems the method at the server side should just use this.userId to determine the userId instead.

@sampaiodiego
Copy link
Contributor

yes.. there is an user case where you want to track the presence of a different entity other than an user. so you can pass "anything" as the "user id".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants