-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] Support for Analyzing Multiple Inputs Applications Together #194
Comments
This issue is currently awaiting triage. |
Let's clarify the CLI arguments for multiple applications analysis, assuming this is not Hub-related, but pure kantra CLI solution. Windup looks to use |
@aufi I think that the main benefit here for having multiple apps, is so that we have a static report generated with multiple apps as part of the assessment. This is particularly useful for microservices, or even larger systems deployed as a handful of deployable units, all part of the same "business application". This will give the end user a single report with all the analysis in a single report. Now, whether |
Adding "feature" to support multiple inputs for kantra. That allows running analysis of multiple applications within a single kantra call and having results in a single statis report. Limitations: - analyses are executed serially one after another and there is _no_ plan on making it paralel (use full Konveyor if need this) - all options (like labels, rules) are shared for all inputs (again no plan on supporting per-input labels etc., use full Konveyor if needed) Since the multiple input analysis execution might take a while, static report is re-generated after each application analysis. Analysis YAML results and log are stored in single output directory in files with name suffix based on input name. Single-input analysis output structure is not changed. TODOs: - include dependencies files in outputs - consider support `input dir` with multiple applications if needed - optimize repeated execution of provider containers&related stuff setup and cleanup Fixes: https://github.com/konveyor/kantra/issues/180 Signed-off-by: Marek Aufart <[email protected]>
It was requested to allow multiple inputs for kantra analyze command. Full multiple inputs support (or a limited/hidden input-bin directory support) would bring unwanted complications for codebase and unwanted usage of kantra tool instead of using Konveyor Hub (discussed in eng team). It looks much cleaner to me to state in README, that kantra analyze is intentionaly a single input command, but allow script multiple inputs analysis on user-side with --bulk command option, that allows run mutliple analysis into the same output directly and create a combined static report. Related to - https://github.com/konveyor/kantra/issues/180 - konveyor#234 (alternative) Signed-off-by: Marek Aufart <[email protected]>
Support multiple inputs with bulk option It was requested to allow multiple inputs for kantra analyze command. Full multiple inputs support (or a limited/hidden input-bin directory support) would bring unwanted complications for codebase and unwanted usage of kantra tool instead of using Konveyor Hub (discussed in eng team). It looks much cleaner to me to state in README, that kantra analyze is intentionaly a single input command, but allow script multiple inputs analysis on user-side with --bulk command option, that allows run mutliple analysis into the same output directly and create a combined static report. Related to - https://github.com/konveyor/kantra/issues/180 - #234 (alternative) Signed-off-by: Marek Aufart <[email protected]> Signed-off-by: Marek Aufart <[email protected]>
PR was merged, docs/usage: https://github.com/konveyor/kantra?tab=readme-ov-file#analyze-multiple-applications |
Related paragraph from kantra readme: Analyze multiple applicationsBy design, kantra supports single application analysis per kantra command execution. However, it is possible use Example: kantra analyze --bulk --input=<path/to/source/A> --output=<path/to/output/ABC>
kantra analyze --bulk --input=<path/to/source/B> --output=<path/to/output/ABC>
kantra analyze --bulk --input=<path/to/source/C> --output=<path/to/output/ABC> |
@aufi I don't understand how that example relates to what @brunoborges was asking for. Could you elaborate further how would that work if I want to analyze applications A, B and C and get the reports for the three of them merged together? |
I think the implementation is almost there. But instead of calling kantra three times with the --bulk parameter, the --input parameter should allow multiple inputs, either by comma separated list, or by adding multiple --input |
Thank you for comment Ramon and Bruno, adding some description what lead us to focus on little different way to getting static report including multiple applications analyses. If the proposed Initialy requested command like below would introduce issues with different input applications technologies, output directory structure incompatible with single application analysis, unexpectable running time before returning the report and our aim move such use-cases primary to use Hub-based Konveyor installation.
The It is true that there was also nearly working PR with initialy requested functionality (currently broken by multiprovider changes and replaced by the multiple inputs with This discussion probably should involve also @pranavgaikwad and @shawn-hurley (when they're available). |
Example of currently proposed solution: In order to run analysis and get single static report covering all 3 applications A, B, C, commands below should be executed (kantra analyze with --bulk option to the same output directory)
|
I should have mentioned one more option we agreed at some point with dev-colleagues and that was not use multiple input fields (or list of applications), but add Example command:
|
Let me summarize current state. There is merged&built upstream solution/workaround combining multiple application analyses into single static report with To fulfil request from this RFE, we might discuss if real multiple |
To be refined to follow @brunoborges' request by 0.6. |
Adding multiple inputs support for kantra analyze command. Fixes: konveyor#194 Signed-off-by: Marek Aufart <[email protected]>
Kantra currently can't analyze input multiple applications at once. Adding this feature would let users analyze several projects together, using the same settings and producing combined reports similar to how Windup supports analyzing multiple applications simultaneously. This change would save time, ensure consistency, and give better insights.
The text was updated successfully, but these errors were encountered: