Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Handle empty code snippets #1472

Closed
1 task done
djzager opened this issue Oct 12, 2023 · 0 comments · Fixed by #1685
Closed
1 task done

[BUG] Handle empty code snippets #1472

djzager opened this issue Oct 12, 2023 · 0 comments · Fixed by #1685
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone
v0.3.1

Comments

@djzager
Copy link
Member

djzager commented Oct 12, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

alpha.6

Priority

Major

Current Behavior

The UI attempts to render incidents that have no code snippet:

Expected Behavior

Don't show empty code snippets

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

No response

Anything else?

Related konveyor/analyzer-lsp#357
@djzager djzager added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 12, 2023
@djzager djzager added this to Planning Oct 12, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Oct 12, 2023
@pranavgaikwad pranavgaikwad added this to the 0.3-beta.2 milestone Oct 16, 2023
@djzager djzager modified the milestones: 0.3-beta.2, v0.3.0 Nov 9, 2023
@dymurray dymurray modified the milestones: v0.3.0, v0.3.1 Jan 30, 2024
@ibolton336 ibolton336 mentioned this issue Feb 13, 2024
Merged
@ibolton336 ibolton336 moved this from 🆕 New to 🏗 In progress in Planning Feb 15, 2024
ibolton336 added a commit that referenced this issue Feb 26, 2024
@ibolton336
🐛 Do not show the code viewer when no code snippet available (#1685)
228abc4 
Resolves #1472 - Adds an
empty state to the codeviewer when the codesnip is not populated / is an
empty string or whitespace characters.


<img width="1188" alt="Screenshot 2024-02-13 at 12 43 05 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/eed3cf5d-e5a4-44eb-846f-6397c50b23a9">

Signed-off-by: Ian Bolton <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Feb 26, 2024
github-actions bot pushed a commit that referenced this issue Feb 26, 2024
@ibolton336 @web-flow
🐛 Do not show the code viewer when no code snippet available (#1685)
9cc4053 
Resolves #1472 - Adds an
empty state to the codeviewer when the codesnip is not populated / is an
empty string or whitespace characters.

<img width="1188" alt="Screenshot 2024-02-13 at 12 43 05 PM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/eed3cf5d-e5a4-44eb-846f-6397c50b23a9">

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
@github-actions github-actions bot mentioned this issue Feb 26, 2024
Merged
ibolton336 added a commit that referenced this issue Feb 26, 2024
@github-actions @ibolton336
🐛 Do not show the code viewer when no code snippet available (#1685) (#…
10728ad 
…1699)

Resolves #1472 - Adds an
empty state to the codeviewer when the codesnip is not populated / is an
empty string or whitespace characters.

<img width="1188" alt="Screenshot 2024-02-13 at 12 43 05 PM"

src="https://github.com/konveyor/tackle2-ui/assets/11218376/eed3cf5d-e5a4-44eb-846f-6397c50b23a9">

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

🐛 Do not show the code viewer when no code snippet available ibolton336/tackle2-ui
3 participants
@djzager @pranavgaikwad @dymurray