Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Selected filters seem to dissappear when not present in opened multi select filter #1774

Closed
1 task done
rszwajko opened this issue Mar 13, 2024 · 1 comment · Fixed by #1903
Closed
1 task done

[BUG] Selected filters seem to dissappear when not present in opened multi select filter #1774

rszwajko opened this issue Mar 13, 2024 · 1 comment · Fixed by #1903
Assignees
@rszwajko
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@rszwajko
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3

Priority

Minor

Current Behavior

Already selected filter (visible as a chip) disappears when its value is not present in currently opened multi select filter.
Screencast from 2024-03-13 14-42-50.webm

Expected Behavior

Selected value does not change.

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response
@rszwajko rszwajko added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 13, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Mar 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Mar 13, 2024
@ibolton336 ibolton336 moved this from 🆕 New to 🔖 Ready in Planning Mar 14, 2024
@rszwajko rszwajko mentioned this issue Mar 25, 2024
Closed
1 task
@rszwajko rszwajko self-assigned this May 7, 2024
@rszwajko rszwajko mentioned this issue May 8, 2024
Merged
sjd78 pushed a commit that referenced this issue May 23, 2024
@rszwajko
🐛 Use separate chip groups for tag categories (#1903)
5900a46 
Use one ToolbarFilter per options group. First filter provides 
the option list. Remaining filters are hidden and used only for
side effects (separate chip groups). The approach follows
similar widgets used by Forklift plugin and OpenShift Console but
uses a flat list of toolbars (nesting trick requires the widget to be
visible all the time).

Related refactorings in MuliselectFilterControl:
1. drop unused feature - using dictionary type for selectedOptions
2. drop state that can be calculated:
   a) active item from focusedItemIndex
   b) selectedOptions from filters
3. centralize id calculations - use prefix based on category title
4. use label styling for tag category part of option

Resolves: #1774 

Reference-Url: kubev2v/forklift-console-plugin#90
Reference-Url: https://github.com/openshift/console/blob/5ba18580676a25e4304df78253aad6a9832d4d56/frontend/public/components/filter-toolbar.tsx#L299

---------

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Planning May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Use separate chip groups for tag categories rszwajko/tackle2-ui
1 participant
@rszwajko