4. Adding Support For VPA and Auto Mode in CreateExperiment [KRUIZE-VPA Integration] #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shekhar Saxena <[email protected]>
shekhar316
changed the title
shekhar316
changed the title
dinogun
reviewed
Dec 13, 2024
Comment on lines
46
to
49
| } else if (kruizeObject.getMode().equalsIgnoreCase(AnalyzerConstants.RECREATE)) { | ||
| setLocal_monitoring(true); | ||
| } else if (kruizeObject.getMode().equalsIgnoreCase(AnalyzerConstants.AUTO)) { | ||
| setLocal_monitoring(true); |
There was a problem hiding this comment.
Maybe a switch case would be more appropriate here
Signed-off-by: Shekhar Saxena <[email protected]>
dinogun
reviewed
Dec 13, 2024
Comment on lines
51
to
52
| case AnalyzerConstants.RECREATE: | ||
| case AnalyzerConstants.AUTO: |
There was a problem hiding this comment.
Please combine this with MONITOR as currently they are all the same
There was a problem hiding this comment.
Sure dino! I have updated the code to use switch case block and combined the RECREATE and AUTO cases with the MONITOR case.
Signed-off-by: Shekhar Saxena <[email protected]>
|
|
dinogun
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
autoandrecreatemodes required for VPA in createExperiment for Local Monitoring.Type of change
How has this been tested?
Tested on both the ResourceHub cluster.
Test Configuration
Kubernetes clusters tested on: ResourceHub (OpenShift)
Checklist 🎯