Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2. Add abstractions for MetadataProfile #1440

Merged
merged 3 commits into from
Jan 24, 2025
Merged

2. Add abstractions for MetadataProfile #1440

merged 3 commits into from
Jan 24, 2025

Conversation

shreyabiradar07
Copy link
Contributor

Description

This PR includes abstractions for MetadataProfile:

  1. The MetadataProfile being the base class.
  2. MetadataProfileValidation and MetadataProfileUtil classes for validating metadata profile and fields.

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

Test Configuration

  • Kubernetes clusters tested on: OpenShift (resource hub)

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

.

@shreyabiradar07 shreyabiradar07 self-assigned this Dec 27, 2024
@shreyabiradar07 shreyabiradar07 added this to the Kruize 0.4 Release milestone Dec 27, 2024
@shreyabiradar07 shreyabiradar07 mentioned this pull request Jan 7, 2025
Draft
12 tasks
@shreyabiradar07
Copy link
Contributor Author

Hi @msvinaykumar, I have incorporated review changes suggested. Can you please review the PR again?
Thanks in advance!

msvinaykumar
msvinaykumar approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@msvinaykumar msvinaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 941e748 into kruize:mvp_demo Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvinaykumar msvinaykumar msvinaykumar approved these changes

@dinogun dinogun Awaiting requested review from dinogun

Assignees

@shreyabiradar07 shreyabiradar07

Labels
enhancement New feature or request local_monitoring
Projects
Monitoring
Status: Done
Milestone
Kruize 0.4 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyabiradar07 @msvinaykumar @dinogun