[wip- Bug Fix] Fixing Delete Experiment API #1461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
Signed-off-by: Shekhar Saxena <[email protected]>
shekhar316
changed the title
|
@shekhar316 - Isn't this same as this PR - #1437? |
|
Closing this PR, as this was already addressed in PR#1437. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue with the delete experiment functionality for the local monitoring use case. Previously, the delete operation was incorrectly attempting to find the experiment in the
KruizeExperimentEntrytable, which is not applicable for local monitoring. The logic has now been updated to use theKruizeLMExperimentEntrytable for local monitoring use case. For cases where ROS is enabled and local monitoring use case, theKruizeExperimentEntrytable will continue to be used.Fixes # (issue)
#1456
Type of change
How has this been tested?
Manually tested on OpenShift cluster (Resource Hub)
Test Configuration
Checklist 🎯
Additional information
Image for testing:
quay.io/rh-ee-shesaxen/autotune:fixDelExp