Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemTags should support comparing with substring, not just full string #8053

Closed
nilo19 opened this issue Jan 17, 2025 · 1 comment · Fixed by #8115
Closed

SystemTags should support comparing with substring, not just full string #8053

nilo19 opened this issue Jan 17, 2025 · 1 comment · Fixed by #8115
Assignees
@Timberlake-Z
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nilo19
Copy link
Contributor

nilo19 commented Jan 17, 2025

What would you like to be added:

We compare if a tag key is system reserved by strings.EqualFold. If the number of system reserved tag keys are huge, SystemTags will be long. For enhancement, we should support comparison with full string and substring at a time, to reduce the length of SystemTags.

Why is this needed:

To reduce the length of SystemTags.
@nilo19 nilo19 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 17, 2025
@Timberlake-Z
Copy link
Contributor

/assign

@Timberlake-Z Timberlake-Z mentioned this issue Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Timberlake-Z Timberlake-Z

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix : Enable system tag support prefix match Timberlake-Z/cloud-provider-azure
2 participants
@nilo19 @Timberlake-Z