Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta2: Class Namespace API change #11500

Open
Tracked by #10852
Danil-Grigorev opened this issue Nov 28, 2024 · 1 comment
Open
Tracked by #10852

v1beta2: Class Namespace API change #11500

Danil-Grigorev opened this issue Nov 28, 2024 · 1 comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Danil-Grigorev
Copy link
Member

Danil-Grigorev commented Nov 28, 2024

We need to implement update to the API definitions of the Cluster object in order to properly leverage cross-namespace ClusterClass references.

Proposed design change:

topology:
  class:
    name: ...
    namespace: ...

which will deprecate introduced addition of the classNamespace field:

topology:
  class: 
  classNamespace: ...

Updated API can leverage +kubebuilder:selectablefield annotation, to add support for server-side indexing (available in k/k 1.32 by default but allowed in CRD schema from version 1.30).

/kind api-change

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 28, 2024
@chrischdi
Copy link
Member

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants