Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage of Machine controller reconcileDelete #11626

Open
sbueringer opened this issue Dec 30, 2024 · 3 comments
Open

Improve test coverage of Machine controller reconcileDelete #11626

sbueringer opened this issue Dec 30, 2024 · 3 comments
Assignees
@arshadd-b
Labels
area/machine Issues or PRs related to machine lifecycle management area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

While adding sorting for hooks in condition messages it came up that we don't have test coverage for this part of the code: #11624 (comment)

The code we changed was adding sorting for hooks via these two PRs:

But the entire code for the pre-terminate and pre-drain hooks in reconcileDelete has no test coverage
@sbueringer sbueringer added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/machine Issues or PRs related to machine lifecycle management area/testing Issues or PRs related to testing labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 30, 2024
@sbueringer sbueringer mentioned this issue Dec 30, 2024
Merged
@arshadd-b
Copy link

/assign

@arshadd-b
Copy link

I am interested and will work on it.

@arshadd-b arshadd-b mentioned this issue Jan 6, 2025
Open
@sbueringer
Copy link
Member Author

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arshadd-b arshadd-b

Labels
area/machine Issues or PRs related to machine lifecycle management area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbueringer @k8s-ci-robot @arshadd-b