Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity e2e tests for the Kueue metrics #3746

Open
mimowo opened this issue Dec 5, 2024 · 5 comments · May be fixed by #3881
Open

Add sanity e2e tests for the Kueue metrics #3746

mimowo opened this issue Dec 5, 2024 · 5 comments · May be fixed by #3881
Assignees
@mykysha
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2024

What would you like to be cleaned:

Add sanity e2e tests to make sure the metrics endpoint returns Kueue metrics.

Why is this needed:

Currently, the metrics.Register() call can be removed from main.go, and all tests pass. This could have caused the bug in this PR: https://github.com/kubernetes-sigs/kueue/pull/3673/files#diff-64a1e0bd9f87bdadd12179b8e48ace63c6aa3ace3f7694375a8a0dd0e566e25dL133
@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 5, 2024
@mimowo mimowo mentioned this issue Dec 5, 2024
Merged
@mimowo
Copy link
Contributor Author

mimowo commented Dec 5, 2024

cc @KPostOffice @mbobrovskyi

@mbobrovskyi
Copy link
Contributor

/assign @mykysha

@k8s-ci-robot
Copy link
Contributor

@mbobrovskyi: GitHub didn't allow me to assign the following users: mykysha.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mykysha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link
Contributor

kannon92 commented Dec 6, 2024

It could be worth adding securing metrics in this test.

@mykysha
Copy link
Contributor

mykysha commented Dec 9, 2024

/assign

@mykysha mykysha linked a pull request Dec 18, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mykysha mykysha

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metrics e2e tests epam/kubernetes-kueue
5 participants
@kannon92 @mykysha @mimowo @mbobrovskyi @k8s-ci-robot