Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report event or record error/info log when drop podUpdates message #129518

Open
zanzan-wang opened this issue Jan 8, 2025 · 5 comments · May be fixed by #129539
Open

Report event or record error/info log when drop podUpdates message #129518

zanzan-wang opened this issue Jan 8, 2025 · 5 comments · May be fixed by #129539
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@zanzan-wang
Copy link

What would you like to be added?

In func (p *podWorkers) UpdatePod(options UpdatePodOptions) (pod_worker.go):
select {
case podUpdates <- struct{}{}:
default:
}
podUpdates buffer is 1, if the previous update message not finish, the new message will drop without any warning.
User cannot get any idea about this. Event or error/info log should added for debugging.

Why is this needed?

The update pod message drop without any warning.
It is better to add some debug log.
@zanzan-wang zanzan-wang added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AmarNathChary
Copy link
Contributor

The proposed enhancement makes sense. This log would help understand the situation without introducing any breaking changes. IMO we could add a debug log (klog.V(4)) in the default

@AmarNathChary
Copy link
Contributor

if it's triaged I will raise a PR for this issue

@AmarNathChary
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2025
@zanzan-wang zanzan-wang linked a pull request Jan 9, 2025 that will close this issue
Open
@zanzan-wang
Copy link
Author

Hello, Mr AmarNathChary
I'm a new member, and want to learn and give little contribute step by step.
Thanks for your suggestions, and feel free to correct my mistakes at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add debug log, when drop pod update message zanzan-wang/kubernetes
3 participants
@k8s-ci-robot @AmarNathChary @zanzan-wang