Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks (searches and documents) #72

Closed
simongray opened this issue Aug 16, 2022 · 5 comments
Closed

Bookmarks (searches and documents) #72

simongray opened this issue Aug 16, 2022 · 5 comments
Labels
enhancement New feature or request nice-to-have

Comments

@simongray
Copy link
Member

It would be a valuable addition to allow storing searches and specific documents as bookmarks, easily accessible by the user. Obviously, this feature requires persistence, so it needs to use the same datastore as the user comments #52.

@simongray simongray added enhancement New feature or request nice-to-have labels Aug 16, 2022
@simongray
Copy link
Member Author

simongray commented Sep 19, 2022

(I think I will start with the bookmarks feature as this is simpler implementation-wise compared with #52)

A bookmark is an entity where the following information is deemed relevant:

{:db/ident          ident
 :bookmark/path     path
 :entity/visibility visibility  ; e.g. :public
 :bookmark/added    date}

Bookmarks need to be persisted, i.e. we will probably need to combine a persisted graph with the in-memory one using asami wrapgraph. The persisted graph should exist in a Docker volume, probably somewhere on disk that gets backed up by KU-IT.

In time, it may be beneficial to view the bookmarks of other users or dynamically compile a list of popular bookmarks. The :entity/visibility attribute is intended to reflect this desire while pre-empting any possible GDPR issues, e.g. bookmarks will default to being publicly visible.

@simongray
Copy link
Member Author

For this purpose, it will be optimal to query/transact to the separate persisted graph directly, since it only interfaces with paths rather than actual document data.

@simongray
Copy link
Member Author

Nice-to-have stuff that is (as of now) still TODO:

  • Frontend changes should take effect immediately and use the callback from the backend request to correct the frontend changes, i.e. clicking on the bookmark button should add it in the frontend and wait for a potentially unsuccessful backend request to remove the bookmark.

@simongray
Copy link
Member Author

Optimistic frontend changes implemented in 242172e

@simongray
Copy link
Member Author

Another nice-to-have documented in #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice-to-have
Projects
None yet
Development

No branches or pull requests

1 participant