Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon is barely visible with Firefox in dark mode #19

Open
Go-rom opened this issue Sep 5, 2024 · 3 comments
Open

Icon is barely visible with Firefox in dark mode #19

Go-rom opened this issue Sep 5, 2024 · 3 comments

Comments

@Go-rom
Copy link

Go-rom commented Sep 5, 2024

Hi,

thank you for this great addon.

Would you be ok to display a white icon when Firefox switches to dark mode please ?

icon_soundcontrol_firefox

Thanks !

@kumar303
Copy link
Owner

kumar303 commented Sep 5, 2024

oh hi, thanks. I don't really work on it anymore but if someone wants to implement the icon I can review the PR and publish it. The icon either came from https://icons8.com/ or https://ionic.io/ionicons . They probably have an inverted version.

@Go-rom
Copy link
Author

Go-rom commented Sep 22, 2024

Hello @kumar303

thank you for your answer, i'm no dev but i'll give it a shot.
Should we consider Sound-Control as an abandoned addon ?

@Go-rom
Copy link
Author

Go-rom commented Sep 25, 2024

Gonna need your help on this one please.
The code is ready but i can't test it.

Whether the browser (Firefox and Chromium), i'm always getting an error saying that it won't load background.js.
Under Chromium, i tried with the 'Load unpacked extension...' feature.
Under Firefox, i tried with a similar feature and a blank profile, the console says :

Loading failed for the <script> with source “moz-extension://9eccd47e-cf55-4ce3-9689-f879439aa44f/dist/background.js”

I even tried by setting up a dev environment with Node.js and Yarn.
Btw, the script asks for Firefox Nightly and not Firefox for developers, don't know why.

I ran the same tests with your master branch with no luck.

Any idea what's going on please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants