Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we going to use purescript-form-urlencoded? #1

Open
paluh opened this issue Mar 9, 2018 · 1 comment
Open

Are we going to use purescript-form-urlencoded? #1

paluh opened this issue Mar 9, 2018 · 1 comment

Comments

@paluh
Copy link
Contributor

paluh commented Mar 9, 2018

If so, we should probably be somewhat consistent with this format of a query:

newtype FormURLEncoded
  = FormURLEncoded
      (Array (Tuple String (Maybe String)))

I think that something like StrMap (Maybe String) should be ok because we can assume that any sane API won't rely on query key order ;-)

Also if we want to handle Arrays (like attr=v1&attr=v2&attr=v3) we probably should use StrMap (Array (Maybe String)).

@paluh
Copy link
Contributor Author

paluh commented Mar 10, 2018

P.S.
Maybe this part of this lib will end up as purescript-urlencoded-generic ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant