Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent email address collision from occuring #525

Closed
lanedirt opened this issue Jan 11, 2025 · 0 comments · Fixed by #527
Closed

Prevent email address collision from occuring #525

lanedirt opened this issue Jan 11, 2025 · 0 comments · Fixed by #527
Labels
bug Something isn't working

Comments

@lanedirt
Copy link
Owner

lanedirt commented Jan 11, 2025 •
edited
Loading

Currently identity generation happens fully on client including email address prefix. However when an alias is saved with an email prefix that is already used by another user this throws an error (as designed).

However the more email claims exist the higher the chances that an email address collision occurs.

Improve this by:

  • Making email prefix more unique (less chance of a collision occurring).
  • Checking if email prefix is used by doing roundtrip to server and if already in use retry generation.
@lanedirt lanedirt added the bug Something isn't working label Jan 11, 2025
@lanedirt lanedirt moved this to Ready in AliasVault Jan 11, 2025
@lanedirt lanedirt changed the title Generate email address on server instead of client to prevent collisions Prevent email address collision from occuring Jan 11, 2025
lanedirt added a commit that referenced this issue Jan 12, 2025
@lanedirt
Add more names to identity generator dictionary to prevent collisions (…
ed80ad2 
…#525)
lanedirt added a commit that referenced this issue Jan 12, 2025
@lanedirt
Add server side email prefix generation method (#525)
e4f2ca6
lanedirt added a commit that referenced this issue Jan 12, 2025
@lanedirt
Refactor email prefix exists check (#525)
92904dc
@lanedirt lanedirt linked a pull request Jan 12, 2025 that will close this issue
Prevent email address collision from occurring during identity generation #527
Merged
@github-project-automation github-project-automation bot moved this from Ready to Done in AliasVault Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
AliasVault
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent email address collision from occurring during identity generation lanedirt/AliasVault
1 participant
@lanedirt