[Sistent] Select component doc #6177
Conversation
nganphan123
force-pushed
the
select-component-doc
branch
2 times, most recently
from
522ad3b to
499335b
Compare
|
🚀 Preview for commit 499335b at: https://67824d17b7b47945fd85e5f8--layer5.netlify.app |
|
Hi @Vidit-Kushwaha , I finished adding the Select component. Could you help review the PR? Thank you! |
|
@nganphan123 adding it as an agenda item to the meeting minutes. |
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
Signed-off-by: nganphan123 <[email protected]>
nganphan123
force-pushed
the
select-component-doc
branch
from
499335b to
4e9faf2
Compare
|
🚀 Preview for commit 4e9faf2 at: https://678f00671bfff88dee48846d--layer5.netlify.app |
| @@ -0,0 +1,13 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
no need of separate file for header. There is file where all components are mentioned.
| import React, { useState } from "react"; | ||
| import Code from "../../../../../components/CodeBlock"; | ||
|
|
||
| export const CodeBlock = ({ name, code }) => { |
There was a problem hiding this comment.
no need of this. using existing code block component
| import TabButton from "../../../../../reusecore/Button"; | ||
| import React from "react"; | ||
| import { useLocation } from "@reach/router"; | ||
| export default function SectionNav() { |
There was a problem hiding this comment.
what is use of this file? Routing is done in one of same file where you have defined component. Checkout existing components.
Description
This PR fixes #5957
Notes for Reviewers
Signed commits