Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KTable]: Add margin to empty text #881

Open
AlexVelezLl opened this issue Jan 6, 2025 · 4 comments
Open

[KTable]: Add margin to empty text #881

AlexVelezLl opened this issue Jan 6, 2025 · 4 comments
Assignees

Comments

@AlexVelezLl
Copy link
Member

Product

Kolibri.

Current behavior

When we have an empty table, we dont have the any margins when showing the empty text as the margins when we show the table when we have data.

E.g.

Look at the margin between the hader and the previous element when we have data:
Image

But if we have an empty table, the empty text is shown without any margin.

Image

Desired behaviour

The empty message should have margin-top: 16px and margin-bottom: 16px just as the margins we have when the table has data.

@karankoder
Copy link

Hey @AlexVelezLl, I want to work on this issue.

@AlexVelezLl
Copy link
Member Author

Hey @karankoder! For sure, will assign this to you :)

@karankoder
Copy link

Hi @AlexVelezLl ,

Thank you for assigning this issue to me! I wanted to let you know that I’m currently observing the correct margin behavior on empty data. Could you kindly provide the steps to reproduce this behavior?

@karankoder
Copy link

Hi @AlexVelezLl,

I hope you're doing well! I just wanted to follow up regarding the steps to reproduce the margin behavior issue with the empty table.

Additionally, could I work on #883 as well? Both issues are related to the KTable component, so I can fix them together in a single PR if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants