Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-ebml license should be GPL? #40

Open
F3n67u opened this issue Apr 18, 2022 · 5 comments
Open

ts-ebml license should be GPL? #40

F3n67u opened this issue Apr 18, 2022 · 5 comments

Comments

@F3n67u
Copy link

F3n67u commented Apr 18, 2022

ts-ebml depend on node-matroska which is GPL license(https://github.com/oeuillot/node-matroska/blob/master/LICENSE).

but in ts-ebml's README state that license is MIT, we should change license to GPL? or replace node-matroska with other project which is not GPL license.

@davedoesdev
Copy link
Contributor

It looks like only matroska/lib/schema is used. node-ebml has a schema.js which could be used instead?

@davedoesdev
Copy link
Contributor

Also worth investigating where matroska/lib/schema originally came from in case it was taken from a different project originally.

@davedoesdev
Copy link
Contributor

node-matroska was originally forked from node-ebml.

@davedoesdev
Copy link
Contributor

davedoesdev commented Jul 2, 2022

I've made https://github.com/davedoesdev/matroska-schema under MIT licence which might be useful here.

It automatically generates schema.js from the Matroska EBML files.

Published on npm as matroska-schema - just require it and you'll get the schema object, identical to node-matroska's.

davedoesdev added a commit to davedoesdev/ts-ebml that referenced this issue Jul 9, 2022
Includes fix for legokichi#40
@thijstriemstra
Copy link
Contributor

thijstriemstra commented Mar 6, 2024

MIT is compatible with GPL license, no need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants