Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A space is missing between title and category. The guillemet symbol is also missing. » #54

Open
a4jp-com opened this issue Dec 21, 2022 · 2 comments

Comments

@a4jp-com
Copy link

a4jp-com commented Dec 21, 2022

I can see the » (») mark is used with some links but others are missing as well as the space. The site title connects to the category.

You can see what I mean here: https://hokkaido.a4jp.com/useronline/

Anyway of adding the » mark between the site title and category name so they aren't touching? Also if a page is missing the space is also missing from the $page_title.

Do we have to edit the wp-useronline/core.php file to fix this around line 195 or the wp-useronline/template-tags.php file? I'm just searching for $page_title at the moment.

@a4jp-com a4jp-com changed the title A space is missing between some pages A space is missing between title and category. The guillemet symbol is also missing. » Aug 26, 2023
@a4jp-com
Copy link
Author

a4jp-com commented Aug 26, 2023

@lesterchan
Line 187 of the core.php file was updated with the code below. It will take time for each entry to update and disappear before the new results start showing up though. Can you add this to the plugin please?

private static function get_title() {
		if ( is_admin() && function_exists( 'get_admin_page_title' ) ) {
			$page_title = '' . __( 'Admin', 'wp-useronline' ) . '' . get_admin_page_title();
		} else {
			$page_title = wp_title( '', false );
			if ( empty( $page_title ) )
				$page_title = '' . strip_tags( $_SERVER['REQUEST_URI'] );
			elseif ( is_singular() )0
				$page_title = '' . $page_title;
		}
		$page_title = get_bloginfo( 'name' ) . ' » ' .$page_title;

		return $page_title;
	}

I removed » from some parts and just put it where it should be.

@lesterchan
Copy link
Owner

Can send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants