Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No such method in RawMusic on libgdx 1.13.0 #97

Open
jetzack opened this issue Nov 22, 2024 · 3 comments
Open

No such method in RawMusic on libgdx 1.13.0 #97

jetzack opened this issue Nov 22, 2024 · 3 comments
Labels

Comments

@jetzack
Copy link

jetzack commented Nov 22, 2024

	public RawMusic (VideoDecoder decoder, ByteBuffer buffer, int channels, int sampleRate) {
		super((OpenALLwjgl3Audio)Gdx.audio, null);
		this.decoder = decoder;
		backBuffer = buffer;
		backBuffer.position(backBuffer.limit());
		setup(channels, sampleRate); // <- here we need additional param 
	}
@SimonIT SimonIT added the bug label Nov 23, 2024
@SimonIT
Copy link
Member

SimonIT commented Nov 23, 2024

You're absolutely right! Thanks for the report. I'm thinking about how to handle this, as I don't want to force everyone to use the latest libGDX version. Maybe we should do a release before the update?

@Frosty-J
Copy link
Contributor

Hello, I'm the one who broke it. Didn't realise gdx-video relies on this. A release would be very much appreciated, since SNAPSHOT builds don't provide a solid foundation for developing a semi-serious game upon. Alternatively, I wouldn't be against adding an overload into libGDX if it makes life easier:

protected void setup (int channels, int sampleRate) {
	setup(channels, 16, sampleRate);
}

@jetzack
Copy link
Author

jetzack commented Nov 29, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants