Error when Porting from Vanilla2+ to Flarum

[MrCaspan]

Hey @linc sorry just tried a port and got the following error, this did work 6 months ago when I first tried it.

[vps58032]$ php porter run -s Vanilla -i source -t Flarum -o target

[ Porter never migrates user permissions! Reset user permissions afterward. ]

Source: Vanilla 2+ (source)
Target: Flarum (target)
Flag: Use Discussion Body: Enabled
export: Category — 34 rows, 00.05s (5.5mb)
inserting 'Comment': 100,000 done...
inserting 'Comment': 200,000 done...
inserting 'Comment': 300,000 done...
export: Comment — 385564 rows, 40.95s (7.4mb)
export: Conversation — 26482 rows, 02.34s (6.9mb)
export: ConversationMessage — 50390 rows, 04.62s (7.3mb)
export: Discussion — 32113 rows, 06.52s (9mb)
export: Media — 2059 rows, 00.21s (6.9mb)
export: Role — 8 rows, 00.02s (5.9mb)
export: Tag — 14 rows, 00.02s (5.9mb)
export: TagDiscussion — 0 rows, 00.02s (0b)
export: User — 52948 rows, 13.51s (9.4mb)
export: UserComment — 3814 rows, 00.16s (6.4mb)
export: UserConversation — 50557 rows, 02.62s (6.7mb)
inserting 'UserDiscussion': 100,000 done...
export: UserDiscussion — 106532 rows, 04.96s (6.4mb)
export: UserMeta — 4836 rows, 00.21s (6.4mb)
export: UserRole — 94185 rows, 02.29s (6.3mb)
export: Badge — 3 rows, 00.02s (5.9mb)
export: UserBadge — 45 rows, 00.02s (5.9mb)
export: Rank — 7 rows, 00.02s (5.9mb)
export: ReactionType — 14 rows, 00.03s (5.9mb)
export: UserTag — 0 rows, 00.02s (0b)
import: users — 52948 rows, 05.58s (7.2mb)
import: groups — 8 rows, 00.02s (6.6mb)
import: group_user — 94185 rows, 02.43s (7mb)Illuminate\Database\QueryException SQLSTATE[42S22]: Column not found: 1054 Unknown column 'id' in 'field list' (SQL: select *, COALESCE(Name, CONCAT("category", id)) as name, if(ParentCategoryID = -1, null, ParentCategoryID) as ParentCategoryID, 0 as is_hidden, 0 as is_restricted from `PORT_Category` where `CategoryID` != -1)
(thrown in /home/dh_vb3jib/.config/composer/vendor/illuminate/database/Connection.php:712)

Stack Trace:

  0) Illuminate\Database\Connection->runQueryCallback('select *, COALESCE(Name, CONCAT("category", id)) as name, if(ParentCategoryID = -1, null, ParentCategoryID) as ParentCategoryID, 0 as is_hidden, 0 as is_restricted from `PORT_Category` where `CategoryID` != ?', [-1], Closure)
     at /home/dh_vb3jib/.config/composer/vendor/illuminate/database/Connection.php:672
  1) Illuminate\Database\Connection->run('select *, COALESCE(Name, CONCAT("category", id)) as name, if(ParentCategoryID = -1, null, ParentCategoryID) as ParentCategoryID, 0 as is_hidden, 0 as is_restricted from `PORT_Category` where `CategoryID` != ?', [-1], Closure)
     at /home/dh_vb3jib/.config/composer/vendor/illuminate/database/Connection.php:389
  2) Illuminate\Database\Connection->cursor('select *, COALESCE(Name, CONCAT("category", id)) as name, if(ParentCategoryID = -1, null, ParentCategoryID) as ParentCategoryID, 0 as is_hidden, 0 as is_restricted from `PORT_Category` where `CategoryID` != ?', [-1], true)
     at /home/dh_vb3jib/.config/composer/vendor/illuminate/database/Query/Builder.php:2591
  3) Illuminate\Database\Query\Builder->Illuminate\Database\Query\{closure}()
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/Storage/Database.php:99
  4) Porter\Storage\Database->store('tags', ['id', 'name', 'slug', 'description', 'parent_id', 'position', 'discussion_count'], ['int', 'varchar(100)', 'varchar(100)', 'text', 'int', 'int', 'int'], Illuminate\Database\Query\Builder, [], Porter\ExportModel)
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/ExportModel.php:254
  5) Porter\ExportModel->import('tags', Illuminate\Database\Query\Builder, ['int', 'varchar(100)', 'varchar(100)', 'text', 'int', 'int', 'int'], ['id', 'name', 'slug', 'description', 'parent_id', 'position', 'discussion_count'])
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/Target/Flarum.php:343
  6) Porter\Target\Flarum->categories(Porter\ExportModel)
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/Target/Flarum.php:192
  7) Porter\Target\Flarum->run(Porter\ExportModel)
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/Controller.php:48
  8) Porter\Controller::doImport(Porter\Target\Flarum, Porter\ExportModel)
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/Controller.php:123
  9) Porter\Controller::run(Porter\Request)
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/src/Command/RunCommand.php:72
  10) Porter\Command\RunCommand->execute()
     at /home/dh_vb3jib/.config/composer/vendor/adhocore/cli/src/Application.php:459
  11) Ahc\Cli\Application->doAction(Porter\Command\RunCommand)
     at /home/dh_vb3jib/.config/composer/vendor/adhocore/cli/src/Application.php:349
  12) Ahc\Cli\Application->handle(['porter', 'run', '-s', 'Vanilla', '-i', 'source', '-t', 'Flarum', '-o', 'target'])
     at /home/dh_vb3jib/.config/composer/vendor/linc/nitro-porter/bin/porter:14
[vps58032]$

Looks like the error is here:
Illuminate\Database\QueryException SQLSTATE[42S22]: Column not found: 1054 Unknown column 'id' in 'field list' (SQL: select *, COALESCE(Name, CONCAT("category", id)) as name, if(ParentCategoryID = -1, null, ParentCategoryID) as ParentCategoryID, 0 as is_hidden, 0 as is_restricted from PORT_CategorywhereCategoryID != -1)

[linc]

Oops #63

[MrCaspan]

@linc When looking at my target database there is no PORT_User table at all. I am not sure if its not being created for some reason or you are using a view so that you can make sure there are no duplicates emails or names before writing? Seems this problem came up since the last fix

[MrCaspan]

I think I found the error it seems like in one of the most recent updates 3.5.0 -> 3.5.1 you removed User from the $tables array and then added some code to add this table later. I am assuming this has to do with the fixing the avatar URL. This is causing the bug it seems. I am not sure if it is being caused too late or what but its causing the PORT_Table to not exist!

v3.5.0...v3.5.1#diff-e14b768118160ef87d8fa341b0f5be24e851329ba10646308581d6657cd48682R65-R99

[MrCaspan]

I added User again to the Array and now there is no error and it seems to have ported but I am not sure if the new code for user avatars worked properly

New issue found though that i have added as a new discussion!

[MrCaspan]

Found the issue:

Simple one, looks like you forgot to call your new users function in /src/Source/Vanilla.php. You need to add:

line 80: $this->users($ex);

If you don't it does not create the User table! I have no idea how to dull pull requests to show the fix but I'm sure you can correct it when you have a minute!

I also found a bug for the new filter that I will post!

[linc]

Thanks! Yeah I made a new method then forgot to call it. 😂 This thing needs more integration tests to catch stuff like that but they're rather tricky to get going.