Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clipboard does not show in primary screen #183

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

yixinshark
Copy link
Contributor

as title

Log: as title
pms: PMS-298897

as title

Log: as title
pms: PMS-298897
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeLists.txt文件中,将dtk_add_dbus_interface更改为qt_add_dbus_interface,需要确认这是否符合项目的需求,因为这两个函数可能具有不同的行为。
  • dbus/org.deepin.dde.daemon.Dock1.xml文件中,删除了多个方法,并添加了新的信号和修改了部分方法的参数类型。需要确保这些更改与客户端代码兼容,并且这些更改是必要的。
  • 删除了dockrect.cppdockrect.hdbusdockinterface.cppdbusdockinterface.h文件,需要确认这些文件是否在其他地方被引用,以及这些更改是否会导致编译错误或运行时错误。
  • mainwindow.cpp文件中,移除了对m_dockInter的使用,并添加了对m_daemonDockInter的使用。需要确保m_daemonDockInter提供了所有m_dockInter所需的功能。
  • mainwindow.cpp文件中,添加了updatePrimaryScreen函数,用于更新主屏幕。需要确保这个函数在所有需要的地方都被正确调用,并且不会引入新的问题。
  • mainwindow.cpp文件中,移除了对m_dockInter的连接,并添加了对m_daemonDockInter的连接。需要确保这些连接是必要的,并且不会导致信号丢失或槽函数未被调用。

是否建议立即修改:

  • 确认dtk_add_dbus_interfaceqt_add_dbus_interface的更改是否符合项目需求。
  • 确认删除的方法和添加的信号是否与客户端代码兼容,并且这些更改是必要的。
  • 确认删除的文件是否在其他地方被引用,以及这些更改是否会导致编译错误或运行时错误。
  • 确保所有对m_daemonDockInter的使用都提供了m_dockInter所需的功能。
  • 确保updatePrimaryScreen函数在所有需要的地方都被正确调用,并且不会引入新的问题。
  • 确保所有对m_daemonDockInter的连接是必要的,并且不会导致信号丢失或槽函数未被调用。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 8193ebd into linuxdeepin:master Jan 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants