Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide Pulseaudio under Treeland #1910

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: Hide Pulseaudio under Treeland #1910

merged 1 commit into from
Dec 12, 2024

Conversation

swq11
Copy link
Contributor

@swq11 swq11 commented Dec 12, 2024

Hide Pulseaudio under Treeland

Log: Hide Pulseaudio under Treeland
pms: BUG-294583

Hide Pulseaudio under Treeland

Log: Hide Pulseaudio under Treeland
pms: BUG-294583
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • initAudioServerData函数中,新增了对Wayland平台的支持,但未对其他平台进行相应的处理。
  • 新增的Wayland平台处理逻辑中,AudioServerData对象的serverName属性被硬编码为"pipewire",这可能不是所有Wayland平台通用的解决方案。

是否建议立即修改:

建议的修改措施:

  • 在新增的Wayland平台处理逻辑中,应该检查并确保"pipewire"是适用于所有Wayland平台的正确服务器名称。
  • 考虑添加对其他平台(如X11)的处理逻辑,以保持代码的完整性和可维护性。
  • 如果AudioServerData对象的serverName属性依赖于平台,应该通过配置文件或环境变量来动态设置,而不是硬编码。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, swq11

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swq11 swq11 merged commit f1d2955 into linuxdeepin:master Dec 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants