Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复movie coredump #556

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jan 10, 2025

修复movie coredump

Bug: https://pms.uniontech.com/bug-view-299235.html
Log: 修复movie coredump

修复movie coredump

Bug: https://pms.uniontech.com/bug-view-299235.html
Log: 修复movie coredump
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. mpv_proxy.cpp文件中,新增的if语句检查了播放列表的大小,但没有对canHwTypes变量进行初始化,可能会导致未定义行为。建议在if语句之前初始化canHwTypes

  2. player_engine.cpp文件中,onSubtitlesDownloaded函数中新增了对播放列表大小的检查,但没有对res变量进行初始化,可能会导致未定义行为。建议在if语句之前初始化res

  3. mircastwidget.cpp文件中,startDlnaTp函数中新增了对播放列表大小的检查,但没有对m_sLocalUrl进行初始化,可能会导致未定义行为。建议在if语句之前初始化m_sLocalUrl

  4. platform_toolbox_proxy.cpp文件中,loadViewProgBar函数中新增了对播放列表大小的检查,但没有对m_seekTime进行初始化,可能会导致未定义行为。建议在if语句之前初始化m_seekTime

  5. platform_toolbox_proxy.cpp文件中,finishLoadSlot函数中新增了对播放列表大小的检查,但没有对bRawFormat进行初始化,可能会导致未定义行为。建议在if语句之前初始化bRawFormat

  6. platform_toolbox_proxy.cpp文件中,updateHoverPreview函数中新增了对播放列表大小的检查,但没有对bRawFormat进行初始化,可能会导致未定义行为。建议在if语句之前初始化bRawFormat

  7. platform_toolbox_proxy.cpp文件中,slotThemeTypeChanged函数中新增了对播放列表大小的检查,但没有对bRawFormat进行初始化,可能会导致未定义行为。建议在if语句之前初始化bRawFormat

  8. platform_toolbox_proxy.cpp文件中,slotFileLoaded函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

  9. platform_toolbox_proxy.cpp文件中,slotUpdateThumbnailTimeOut函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

  10. platform_toolbox_proxy.cpp文件中,progressHoverChanged函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

  11. platform_toolbox_proxy.cpp文件中,updateButtonStates函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

  12. toolbox_proxy.cpp文件中,finishLoadSlot函数中新增了对播放列表大小的检查,但没有对bRawFormat进行初始化,可能会导致未定义行为。建议在if语句之前初始化bRawFormat

  13. toolbox_proxy.cpp文件中,updateHoverPreview函数中新增了对播放列表大小的检查,但没有对bRawFormat进行初始化,可能会导致未定义行为。建议在if语句之前初始化bRawFormat

  14. toolbox_proxy.cpp文件中,slotFileLoaded函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

  15. toolbox_proxy.cpp文件中,progressHoverChanged函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

  16. toolbox_proxy.cpp文件中,updateButtonStates函数中新增了对播放列表大小的检查,但没有对isAllAudio进行初始化,可能会导致未定义行为。建议在if语句之前初始化isAllAudio

以上是代码审查意见,希望对你有所帮助。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Jan 10, 2025

/merge

@deepin-bot deepin-bot bot merged commit 0a8a5b1 into linuxdeepin:release/1070 Jan 10, 2025
15 checks passed
@myk1343 myk1343 deleted the uploadcode branch January 17, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants