Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkgui #83

Merged
merged 1 commit into from
Nov 26, 2024
Merged

sync: from linuxdeepin/dtkgui #83

merged 1 commit into from
Nov 26, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-278-nosync branch 2 times, most recently from ffde703 to 30e0667 Compare November 26, 2024 04:19
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#278
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DPlatformHandle的析构函数中,使用g_platformThemeMap.take(this)替代了原来的valueremove方法,这是一个更安全、更高效的操作。
  • setEnabledNoTitlebarForWindow函数中,直接将enable参数传递给handle->setEnabledNoTitlebar,避免了不必要的布尔值比较。

是否建议立即修改:

  • 否,提交的代码没有明显的错误,并且改进了代码的效率和安全性。

@mhduiy mhduiy merged commit 4d3f24d into master Nov 26, 2024
9 of 13 checks passed
@mhduiy mhduiy deleted the sync-pr-278-nosync branch November 26, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants