Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons with Expiry block needs updating #770

Open
thetwopct opened this issue Apr 26, 2023 · 2 comments
Open

Buttons with Expiry block needs updating #770

thetwopct opened this issue Apr 26, 2023 · 2 comments
Assignees
@thetwopct

Comments

@thetwopct
Copy link
Collaborator

thetwopct commented Apr 26, 2023 •
edited
Loading

The buttons with expiry block needs updating (misaligned settings in the WordPress Editor sidebar)

https://github.com/WordPress/gutenberg/tree/trunk/packages/block-library/src/buttons
@thetwopct thetwopct self-assigned this Apr 26, 2023
@thetwopct
Copy link
Collaborator Author

New error for this one

[Warning] Block type "lf/button-with-expiry" must support API version 2 or higher to work correctly with "useBlockProps" method. (gutenberg.js, line 7577)

@cjyabraham cjyabraham moved this to In progress in lfevents Jun 2, 2024
cjyabraham added a commit that referenced this issue Nov 24, 2024
@cjyabraham
Fixes rendering of date controls in sidebar (#770)
3da475c 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham cjyabraham mentioned this issue Nov 24, 2024
Merged
@cjyabraham
Copy link
Collaborator

cjyabraham commented Nov 24, 2024 •
edited
Loading

I've added a fix for the misaligned date controls in CSS. I'm not sure if that's the best way to fix it or if there is a deeper fix required.

The "Warning" in the console is still a problem and I'm seeing an additional one:

react-dom.js?ver=1719715772:73 Warning: Each child in a list should have a unique "key" prop. 
See https://reactjs.org/link/warning-keys for more information.
    at https://lfeventsci.lndo.site/wp-content/plugins/countdown-block/dist/blocks.build.js?ver=1719715772:1:1655

cjyabraham added a commit that referenced this issue Dec 8, 2024
@cjyabraham
Fixes rendering of date controls in sidebar (#770)
ccd464d 
Signed-off-by: Chris Abraham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thetwopct thetwopct

Labels
None yet
Projects
lfevents
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjyabraham @thetwopct