Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health Check Probe #2903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Health Check Probe #2903

wants to merge 1 commit into from

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Jan 9, 2025 •
edited
Loading

Description

This PR adds health check in networking components

The gateway probe is disabled (commented in templates) by default , to avoid unready pods in case of multiple replicas

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the feat Adds a new feature to the codebase label Jan 9, 2025
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jan 9, 2025
@cheina97 cheina97 marked this pull request as draft January 9, 2025 15:01
@cheina97 cheina97 changed the title feat: fabric ports setup Health Check Probe Jan 9, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 9, 2025
@cheina97 cheina97 force-pushed the frc/fabricport branch 2 times, most recently from 754d80e to 7c6682e Compare January 9, 2025 15:20
@cheina97
Copy link
Member Author

cheina97 commented Jan 9, 2025

/build

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 9, 2025
@cheina97
Copy link
Member Author

cheina97 commented Jan 9, 2025

/build

@cheina97 cheina97 force-pushed the frc/fabricport branch 5 times, most recently from 64bc9a3 to 3c4dd1e Compare January 9, 2025 18:02
@cheina97
Copy link
Member Author

cheina97 commented Jan 9, 2025

/build

@cheina97 cheina97 force-pushed the frc/fabricport branch 3 times, most recently from 28d48d1 to a719216 Compare January 10, 2025 11:10
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 marked this pull request as ready for review January 10, 2025 11:41
@cheina97 cheina97 force-pushed the frc/fabricport branch 2 times, most recently from 36216e8 to 6dc26d4 Compare January 10, 2025 12:15
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 requested review from aleoli and fra98 January 10, 2025 12:20
@cheina97
Copy link
Member Author

/rebase test=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@aleoli aleoli Awaiting requested review from aleoli

Assignees
No one assigned
Labels
feat Adds a new feature to the codebase size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @fra98